Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new release] pp (1.1.2) #18423

Merged
merged 3 commits into from Mar 31, 2021
Merged

[new release] pp (1.1.2) #18423

merged 3 commits into from Mar 31, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 31, 2021

Pretty-printing library

CHANGES:

@jeremiedimino
[new release] pp (1.1.2)
2efa1d9 
CHANGES:

- Add `of_fmt` to compose with existing pretty printers written in `Format`
  (ocaml-dune/pp#1, @Drup).

- Use a tail-recursive `List.map` to fix a stack overflow issue (ocaml-dune/pp#3,
  @emillon)

- Add `Pp.custom_break` (ocaml-dune/pp#4, @gpetiot)

- Add `Ast` sub-module to expose a stable representation for
  serialization, allowing to do the rendering in another process (ocaml-dune/pp#6,
  @rgrinberg)
@mseri
Copy link
Member

mseri commented Mar 31, 2021 •
edited
Loading

There are some failures on

#=== ERROR while compiling pp.1.1.2 ===========================================#
# context              2.0.8 | linux/x86_64 | ocaml-base-compiler.4.07.1 | pinned(https://github.com/ocaml-dune/pp/releases/download/1.1.2/pp-1.1.2.tbz)
# path                 ~/.opam/4.07/.opam-switch/build/pp.1.1.2
# command              ~/.opam/4.07/bin/dune build -p pp -j 47 @install
# exit-code            1
# env-file             ~/.opam/log/pp-15-89b24d.env
# output-file          ~/.opam/log/pp-15-89b24d.out
### output ###
#       ocamlc src/.pp.objs/byte/pp.{cmo,cmt} (exit 2)
# (cd _build/default && /home/opam/.opam/4.07/bin/ocamlc.opt -w -40 -g -bin-annot -I src/.pp.objs/byte -intf-suffix .ml -no-alias-deps -o src/.pp.objs/byte/pp.cmo -c -impl src/pp.ml)
# File "src/pp.ml", line 151, characters 30-51:
# Error: Unbound value pp_print_custom_break
#     ocamlopt src/.pp.objs/native/pp.{cmx,o} (exit 2)
# (cd _build/default && /home/opam/.opam/4.07/bin/ocamlopt.opt -w -40 -g -I src/.pp.objs/byte -I src/.pp.objs/native -intf-suffix .ml -no-alias-deps -o src/.pp.objs/native/pp.cmx -c -impl src/pp.ml)
# File "src/pp.ml", line 151, characters 30-51:
# Error: Unbound value pp_print_custom_break

and I don't know what bounds I need to add for it

mseri
mseri reviewed Mar 31, 2021
View reviewed changes
packages/pp/pp.1.1.2/opam Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Mar 31, 2021

Seems like we need at least 4.08. @rgrinberg is 4.08 fine for your use case?

@camelus
Copy link
Contributor

camelus commented Mar 31, 2021 •
edited
Loading

Commit: 32ea6df

A pull request by opam-seasoned @jeremiedimino.

☀️ All lint checks passed 32ea6df
  • These packages passed lint tests: pp.1.1.2
☀️ Installability check (+0)

@rgrinberg
Copy link
Member

Yes, that's the lower bound I use everywhere as well.

mseri
mseri reviewed Mar 31, 2021
View reviewed changes
packages/pp/pp.1.1.2/opam Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Mar 31, 2021

Ack, I updated the upstream opam file as well

@kit-ty-kate
Copy link
Member

Looks good now. Thanks!

@kit-ty-kate kit-ty-kate merged commit a016e24 into ocaml:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs reporter action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mseri @camelus @rgrinberg @kit-ty-kate @jeremiedimino